mvolkmann / waxy

WAX - a new approach to writing XML
http://java.ociweb.com/mark/programming/wax.html
2 stars 0 forks source link

No way to add PUBLIC DTDs? #29

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
In the current Java implementation, I can't see a way to add a PUBLIC
doctype, like 

<!DOCTYPE chapter PUBLIC "-//OASIS//DTD DocBook XML//EN"
          "../dtds/chapter.dtd">

I modified my JS implementation like

/**
 * Writes a DOCTYPE that associates a PUBLIC or SYSTEM DTD with the XML
document. 
 * @param {String } identifier (Optional, may be ommited) the public DTD
identifier
 * @param {String } filePath the path to the DTD
 * @return {WAX} this WAX instance
 */
WAX.prototype.dtd = function(identifier, filePath) {//...

Adding this as a defect since it's an essential feature (well, if I'm right)

Original issue reported on code.google.com by manosbat...@gmail.com on 20 Sep 2008 at 4:57

GoogleCodeExporter commented 9 years ago
This was recently added as issue #23 and I already implemented in the Java 
version. However, while it's in 
Subversion, I haven't make another release yet, so you couldn't see the new 
javadoc for it. The way I handle this 
is to accept two parameters in the dtd method. If you agree with that solution 
then we can close this one. Have a 
look at the testDTDPublic method in WAXTest.java at 
http://code.google.com/p/waxy/source/browse/trunk/java/test/com/ociweb/xml/WAXTe
st.java.

Original comment by r.mark.v...@gmail.com on 21 Sep 2008 at 1:58

GoogleCodeExporter commented 9 years ago
Duh. Need to check out the trunk if i'm going to go over the java code in the 
future :-)

I did it the same way for JS. Closing this.

Original comment by manosbat...@gmail.com on 21 Sep 2008 at 10:49