search

mvondracek / PA193_mnemonic_Slytherin

BIP39 Mnemonic Phrase Generator and Verifier
0 stars 2 forks source link

Task 26 class representation #36

Closed mvondracek closed 4 years ago

mvondracek commented 4 years ago

26, https://github.com/mvondracek/PA193_mnemonic_Slytherin/issues/26#issuecomment-544248885

mvondracek commented 4 years ago

@sobuch thanks for the work on this class model, let me know what do you think about the comments.

sobuch commented 4 years ago

should we check the types of arguments in public methods?

codeclimate[bot] commented 4 years ago

Code Climate has analyzed commit e24a6362 and detected 6 issues on this pull request.

Here's the issue category breakdown:

Category Count
Bug Risk 3
Complexity 3

View more on Code Climate.

sobuch commented 4 years ago

@mvondracek please set codeclimate's warning as known, when its in dev, so we will notice new ones.