mvondracek / PA193_mnemonic_Slytherin

BIP39 Mnemonic Phrase Generator and Verifier
0 stars 2 forks source link

WIP: add more tests #41

Closed sobuch closed 4 years ago

sobuch commented 4 years ago

discovered problem in entropy init, but it can wait here with other possible minor issues tests could uncover until the merge. Its not in any way critical.

sobuch commented 4 years ago

If you want more tests for some reason, feel free to use this branch. I will continuously update it to see whether test coverage increases.

sobuch commented 4 years ago

Also, @mvondracek as we discussed earlier, that it would be useful to run cli tests twice to record coverage - does this need some support on the script side or is it something that can be configured here in github?

mvondracek commented 4 years ago

Also, @mvondracek as we discussed earlier, that it would be useful to run cli tests twice to record coverage - does this need some support on the script side or is it something that can be configured here in github?

I'll set it up.

mvondracek commented 4 years ago

This is still work in progress.

mvondracek commented 4 years ago

Closes #40.

mvondracek commented 4 years ago

Tests, fixes of bugs, relevant refactoring of other code, and 99 % test coverage. 🎉 Some tests could be refactored for better structure, but I would merge it now in order to start with fixing #50, #51, #52, #55, ...

@sobuch, as you created this PR, you cannot set approval via GitHub UI, so please leave your feedback here in comments. :)

mvondracek commented 4 years ago

Closes #40.

codeclimate[bot] commented 4 years ago

Code Climate has analyzed commit c0c173fe and detected 32 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 20
Bug Risk 12

View more on Code Climate.

sobuch commented 4 years ago

I think the tests look great. Lets merge this

mvondracek commented 4 years ago

Waits for review from @lsolodkova