search

mvondracek / PA193_mnemonic_Slytherin

BIP39 Mnemonic Phrase Generator and Verifier
0 stars 3 forks source link

PBKDF2 implementation #42

Closed lsolodkova closed 5 years ago

lsolodkova commented 5 years ago

PBKDF2 is implemented as external function together with one auxiliary function for XOR'ing byte arrays. Should I make'em class methods?

mvondracek commented 5 years ago

What's the status? // @lsolodkova, @sobuch

lsolodkova commented 5 years ago

Well, what status? I've replaced library function with manual implementation and added password length check.

mvondracek commented 5 years ago

Great! Is it tested? Will it be ready for merge to dev once it has tests?

    1. 2019 v 9:56, lsolodkova notifications@github.com:

Well, what status? I've replaced library function with manual implementation and added password length check.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub, or unsubscribe.

codeclimate[bot] commented 5 years ago

Code Climate has analyzed commit acf23c09 and detected 0 issues on this pull request.

View more on Code Climate.

mvondracek commented 5 years ago

I'm happy to merge this. @sobuch, please have a look at it.