mvondracek / PA193_mnemonic_Slytherin

BIP39 Mnemonic Phrase Generator and Verifier
0 stars 3 forks source link

Task 39 fuzzer #57

Closed sobuch closed 5 years ago

sobuch commented 5 years ago

simple fuzzer using radamsa

sobuch commented 5 years ago

now shows logs in stderr, for the time being I think its better to leave the other exit codes from mnemoniccli.ExitCode as fails, since they seem more likely to indicate problems with fuzzer than the code.

Eg. 'EX_NOINPUT = 66 """An input file (not a system file) did not exist or was not readable."""'

sobuch commented 5 years ago

i think the rest of style issues are false positives, as we have to check against several values. If you know of a way to do that dirrectly please let me know

mvondracek commented 5 years ago

@sobuch

mnemoniccli -g -e entropy_bin -s seed -m mnemonic -f bin -ll debug &>out
exit_code=$?
if [[ ${exit_code} != 0 && ${exit_code} != 65 ]] ;
mvondracek commented 5 years ago

@sobuch, Please add fuzzing of --password for various actions.

sobuch commented 5 years ago

@sobuch

mnemoniccli -g -e entropy_bin -s seed -m mnemonic -f bin -ll debug &>out
exit_code=$?
if [[ ${exit_code} != 0 && ${exit_code} != 65 ]] ;

this is the same thing as i did just longer, what codeclimate is sugesting is something like if ! make mytarget then echo "Build failed" fi which I dont know how to do

sobuch commented 5 years ago

rebased on dev

mvondracek commented 5 years ago

Closes #39

mvondracek commented 5 years ago

Pending review, @lsolodkova

codeclimate[bot] commented 5 years ago

Code Climate has analyzed commit a95de367 and detected 0 issues on this pull request.

View more on Code Climate.