search

mvondracek / PA193_mnemonic_Slytherin

BIP39 Mnemonic Phrase Generator and Verifier
0 stars 2 forks source link

Resolving encoding issues #60

Closed lsolodkova closed 4 years ago

lsolodkova commented 4 years ago

Will answer #51 and #52.

mvondracek commented 4 years ago

When this PR is ready for review, please change status from draft and assign reviewers so we get notification. :)

lsolodkova commented 4 years ago

Can't write a proper test for non-Unicode entropy/seed, exception occurs not while reading file, but only in unhexlify(). Any hints will be appreciated.

sobuch commented 4 years ago

please rebase on dev so we can fuzz this a little

lsolodkova commented 4 years ago

Rebased on dev.

lsolodkova commented 4 years ago

Tests for non-Unicode entropy/seed work properly only if encoding is given explicitly in read() function (but I'm not able to make so cardinal changes to the code), otherwise we fail only inside unhexlify().

mvondracek commented 4 years ago

See #64 and #65

codeclimate[bot] commented 4 years ago

Code Climate has analyzed commit 626a9327 and detected 25 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 16
Style 3
Security 4
Bug Risk 2

View more on Code Climate.