search

mvondracek / PA193_mnemonic_Slytherin

BIP39 Mnemonic Phrase Generator and Verifier
0 stars 3 forks source link

change in fuzzing to enable running in travis #66

Closed sobuch closed 5 years ago

sobuch commented 5 years ago

Prepared changes to fuzzing so we can run it in travis, since we always fuzz 10 times in one run, PA193MNEMONICSLYTHERIN_FUZZ_TEST_COUNT should be a multiple of 10

codeclimate[bot] commented 5 years ago

Code Climate has analyzed commit 9d6deff3 and detected 0 issues on this pull request.

View more on Code Climate.

sobuch commented 5 years ago

its supposed to be like that, so that if the env variable is not defined, it acts just the way it did before and you can run it on your machine forever

Dňa št 31. 10. 2019, 14:42 Martin Vondráček notifications@github.com napísal(a):

@mvondracek commented on this pull request.

In fuzz/run.sh https://github.com/mvondracek/PA193_mnemonic_Slytherin/pull/66#discussion_r341141563 :

@@ -8,7 +10,7 @@ handle_fail() fails=0 runs=0 echo -n "" > fails -while true +while [[ runs -ne TEST_COUNT ]]

Or don't do != here, but runs <

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/mvondracek/PA193_mnemonic_Slytherin/pull/66?email_source=notifications&email_token=ANM6LPX4MGDUUX7LH37YJ23QRLOD5A5CNFSM4JHHS6Z2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCJ4HV3A#pullrequestreview-309885676, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANM6LPTISOWJ645NZUAT7QTQRLOD5ANCNFSM4JHHS6ZQ .

mvondracek commented 5 years ago

OK