search

mvrdevelopment / spec

DIN SPEC 15800 General Device Type Format (GDTF) and My Virtual Rig (MVR) File Format description DIN SPEC 15801
64 stars 13 forks source link

GDTFSpec and GDTFMode children in MVR #145

Closed s-montanus closed 1 year ago

s-montanus commented 1 year ago

Currently the nodes SceneObject, Truss, Fixture, Support, Projector and VideoScreen all have an optional ( 0 or 1 ) GDTFSpec child node, Shouldn't the GDTFSpec child be mandatory for Fixture, Projector and VideoScreen nodes ?

Also the nodes with an optional GDTFSpec child have a mandatory GDTFMode child. Shouldn't the GDTFMode be mandatory if and only if the GDTFSpec is present ? And isn't it then more logical to have the GDTFMode node be a child of the GDTFSpec node ?

moritzstaffel commented 1 year ago

https://github.com/mvrdevelopment/spec/commit/d84903956aee40ee7b5afbdec59c0224383d9843

moritzstaffel commented 1 year ago

Also the nodes with an optional GDTFSpec child have a mandatory GDTFMode child. Shouldn't the GDTFMode be mandatory if and only if the GDTFSpec is present ? And isn't it then more logical to have the GDTFMode node be a child of the GDTFSpec node ?

Yes that is true. But as we don't want to break Backward Compatibly, I would not change it. But I have clarified for the spec, the relation between this.

Shouldn't the GDTFSpec child be mandatory for Fixture, Projector and VideoScreen nodes ? We want to allow to define this objects still by Geometry mode. And we want to align the behavior between the objects types. The same thing applies for trusses for example. When you define the structure in the GDTF, you could calculate the truss. But I think we need to make this a step by step transmission.