mvrdevelopment / spec

DIN SPEC 15800 General Device Type Format (GDTF) and My Virtual Rig (MVR) File Format description DIN SPEC 15801
64 stars 13 forks source link

Delimiter for DMXChannel Allows Non-Unique Channel Names #92

Closed Firionus closed 3 years ago

Firionus commented 3 years ago

Problem

The following clash of DMXChannel names is not prohibited by the GDTF standard:

This is because the Name Type allows underscores, which are also used as a delimiter between Geometry and Attribute for the name of the DMXChannel.

Proposed Solution

Require in the standard that DMXChannel Names as computed from Geometry and Attribute of the first Logical Channel must be unique.

Alternative Solutions

nicavolites commented 3 years ago

Personally I would prefer the proposed solution or changing the Geometry name to a different type that has does not permit underscore. The alternative solutions will impact parsing.

moritzstaffel commented 3 years ago

I think the proposed version is good.

I think we never made it clear in the Spec that we assume this. Have have added this in the new proposal for the spec.

Bildschirmfoto 2021-08-25 um 14 41 53

here is the proposed change on the Spec text.

Note that you can get the full spect text here: https://www.beuth.de/de/technische-regel/din-spec-15800/324748671 That is currently the only place where you find the full spec online.

nicavolites commented 3 years ago

Looks good to me. As a minor point I think 'consists' should be 'consist'.