About Echo implementation

[luisnquin]

Hi, I really like the project @mvrilo but there's some suggestions that I think could improve the project, between these are:

• The echo example could be updated for something like this:

  The problem with use a middleware for just show documentation is that overwrites all other endpoints.

  

• Other things that I'm sure that goes well to the package is the json/yaml tags for the structs, more than nothing because normally the HTTP Servers have configuration files and directly set everything in that configuration file sounds good.

• Another improvement could be the favicon.ico implementation, in the same way the openapi.yaml is provided in my case.

I don't know if I can open a merge request to make these changes, ready to hear your opinion, me.

[mvrilo]

Hey @luisnquin, sorry the delay and thanks for reaching out!

The problem with use a middleware for just show documentation is that overwrites all other endpoints.

This sounds like a bug actually, looking at the code the middlewares should be calling the Next method in the end so we don't stop other handlers to be called afterwards. I'll push a fix for that this weekend.

Other things that I'm sure that goes well to the package is the json/yaml tags for the structs, more than nothing because normally the HTTP Servers have configuration files and directly set everything in that configuration file sounds good.

Not sure about this. Are you talking about loading from a config file directly into a Redoc struct?

Another improvement could be the favicon.ico implementation, in the same way the openapi.yaml is provided in my case.

Makes sense. Any thoughts on adding a Favicon field on the Redoc struct for this? Could you open a PR for this?

[mvrilo]

I just pushed a v0.1.2 fixing the next handlers issue for gin and echo.