mvrozanti / RAT-via-Telegram

Windows Remote Administration Tool via Telegram
MIT License
646 stars 347 forks source link

Issue in requirements #50

Closed dudeisbrendan03 closed 5 years ago

dudeisbrendan03 commented 5 years ago

cv2 isn't a thing, my bad.

Change cv2 for opencv-python

mvrozanti commented 5 years ago

Fixed! 9fca1c504f4be81fd66369a4b052d2f0b8c2ebf5

dudeisbrendan03 commented 5 years ago

Thanks

mvrozanti commented 5 years ago

@dudeisbrendan03 may I ask, why did you add --hidden-import ctypes to compilation? I can't run it for some reason.

dudeisbrendan03 commented 5 years ago

I might have placed it in the wrong place. Haven't tested it. Need it to stop all those pop-ups about api-*.dll missing.

mvrozanti commented 5 years ago

@dudeisbrendan03 I just noticed you added a dependency, consoletools; which you're hosting on pypi. Can you explain why exactly is this necessary?

dudeisbrendan03 commented 5 years ago

It's been on there for a while, it's a tool that is used for logging and adding some fancy text on output

mvrozanti commented 5 years ago

I think it's a great idea -- small reusable tools -- it's the suckless-* way to do something; but it does add yet another piece of code to look at that can change in parallel with this repo. We already have got python's large logging module. Perhaps we should stick to it otherwise I think people would get either suspicious of compiling a RAT with many dependencies or would have to spend a bit of time looking up what's in there. Do you agree?

dudeisbrendan03 commented 5 years ago

Tbh I just did it for the colours. The project came from me and a couple of friends are working on a large project and the console spits out a load of data, some we didn't want in the console only logged and some needed to be pointed out. So we made a module where you can just classify spam and add colours

dudeisbrendan03 commented 5 years ago

If you want to remove it go ahead