Closed dudeisbrendan03 closed 5 years ago
Thanks
May I remind that checksum validation should not be necessary if we are installing wheels with pip install [wheel url]
. It does add a little bloat. Mind if we remove hashverify.py
? We can keep setup.py
and the Quick deploy section in README I think. I'll accept this PR as soon as this is resolved
I'll delete the checksum verifier then merge it then. Is that fine with you @mvrozanti?
Sounds great
Pull Request Template
Please follow this format by copying and pasting or otherwise
Describe this request in around 8 words: Logging
Does this request fix an issue, add a feature or otherwise (what is the purpose of the request): Improves logging
If this is related to an issue, specify the issue in hand: n/a
If this is related to a commit, specify the commit in hand: n/a
If this adds a feature, specify the feature you are adding/improving: Logging
Give a detailed description of what the PR contains, and the reasoning behind it: Logs to files in
logs/DATE-log.txt