Bzlmod Migration - Githubissues

mvukov / rules_ros2

Build ROS 2 with Bazel

Apache License 2.0

81 stars 45 forks source link

Bzlmod Migration #173

Closed silicon-ninja closed 6 months ago

silicon-ninja commented 1 year ago

Hey @mvukov ,

Will keep on updating the PR ... as we move on bzlmod transition

silicon-ninja commented 1 year ago

So few things !

I've added .devcontainer for vscode development its easier to develop inside docker for this project to isolate all the code.
Trying to make sure that to see if poetry would help us cross compile the code to aarch64 only issue i found was netifaces maybe has to be recompiled with clang for the wheel file since it only supports x86 and poetry throws an error since it could not find it for my laptop (ARM64)
I am also experimenting with hermetic_cc_toolchain which uses zig to compile the c/cpp code ! lot faster and less configuration required for clang. since zig uses clang underneath it.

Please let me know your thoughts on this ! so we could proceed further accordingly ... Thanks 😁

mvukov commented 1 year ago

This work is still fresh, so converted it to draft. As-is right now, the PR has some unrelated changes. If you want to introduce bzlmod, I'd suggest to "just" do that in this PR and leave rules_poetry, cross-compilation, dev containers for follow-up PRs. This way the PR is going to be much shorter and easier to review.

oh-tarnished commented 1 year ago

This work is still fresh, so converted it to draft. As-is right now, the PR has some unrelated changes. If you want to introduce bzlmod, I'd suggest to "just" do that in this PR and leave rules_poetry, cross-compilation, dev containers for follow-up PRs. This way the PR is going to be much shorter and easier to review.

Hey thank you, So well I could link multiple issues with this PR for rules_poetry, cross-compilation, dev containers to follow up .... I thought to wrap it up in one go. but sure if you wanna do that I could only make it for bzlmod

mvukov commented 1 year ago

Follow-ups should go to follow-up PRs, this one should be as small as possible.