mvukov / rules_ros2

Build ROS 2 with Bazel
Apache License 2.0
84 stars 45 forks source link

fix hardcoded release mode in cyclonedds build #262

Closed getim closed 8 months ago

getim commented 8 months ago

The BUILD-files for cyclonedds and iceoryx hardcode CMAKE_BUILD_TYPE to Release. This causes debug builds (--compilation_mode=dbg) to fail because the cyclonedds CMake build can't find its iceoryx dependency. I think it's still looking for a release version of its dependency but fails to do so because some part of the debug configuration still makes it into the iceoryx build, although I'm not entirely sure what's happening.

The cmake-rule actually already sets CMAKE_BUILD_TYPE automatically based on the compilation mode here. Leaving the decision to that part of the rule itself makes the debug build work.