mvysny / aedict

Original Aedict 2 source codes
http://www.aedict.eu
GNU General Public License v3.0
40 stars 7 forks source link

Get rid of the extra screen for search results #288

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Type something into the search box
2. Hit the return / search button on keyboard
3. Click on one of the results
4. Press back button

What is the expected output? What do you see instead?
Expect to go back to the main search screen with search bar. Instead, go back 
to the search results without the search bar.

What version of Android are you using?
4.2

Please provide any additional information below.
If we never hit the return button on the keyboard (i.e. just let search results 
auto-populate on key input), then this problem doesn't occur. I think this 
extra screen in the navigation hierarchy is completely unnecessary... hitting 
the return button should just stay on that same screen, and do an immediate 
search.

Original issue reported on code.google.com by perceptu...@gmail.com on 10 Jul 2014 at 1:40

GoogleCodeExporter commented 9 years ago
Hitting the search button on the keyboard should close the keyboard as well

Original comment by perceptu...@gmail.com on 10 Jul 2014 at 2:09

GoogleCodeExporter commented 9 years ago
> hitting the return button should just stay on that same screen, and do an 
immediate search.

This imho really has no effect because live search is updated on search box 
change, and Enter does not really add any characters.

If live search is enabled, the "search" button is not shown. Enter is 
equivalent to the "search" button and should therefore be disabled. Please 
correct me if I am wrong.

Original comment by martin.v...@gmail.com on 10 Jul 2014 at 10:27

GoogleCodeExporter commented 9 years ago
yes disabling it would be fine, but you could also just hide the keyboard on 
enter press, it doesn't really hurt anyone and is more intuitive for people 
that don't realize live search is enabled (due to the delay between typing and 
the search results appearing).

Original comment by perceptu...@gmail.com on 10 Jul 2014 at 10:37

GoogleCodeExporter commented 9 years ago
Sure, I can do that. Keyboard hiding may not work 100% though as this 
particular Android API is horribly broken :(

Original comment by martin.v...@gmail.com on 10 Jul 2014 at 10:47

GoogleCodeExporter commented 9 years ago
Thanks for the bug report, fixed in 3.4.20.

Original comment by martin.v...@gmail.com on 10 Jul 2014 at 11:56

GoogleCodeExporter commented 9 years ago
Reopening, as users not using live search find it confusing that the search 
results screen is closed silently. The search results screen now contains 
search box which allows further search, so I'm strongly convinced to revert 
this fix and stop hiding the search results screen.

Original comment by martin.v...@gmail.com on 7 Mar 2015 at 7:13

GoogleCodeExporter commented 9 years ago
OK I'm open to changes, as long as we never end up on a screen that doesn't 
have a search bar

Original comment by perceptu...@gmail.com on 7 Mar 2015 at 7:26

GoogleCodeExporter commented 9 years ago
Sure, the search stays. The use case for the change is as follows, quoting:

"When I want to do a new search, I write the word on the omnisearch box in the 
recent entries screen (screen 1) and then, the results appear (screen 2). At 
this moment, if I select an option, another screen with meaning, kanji, 
examples and inflections appears (screen 3). Then, if I push back button, 
screen 1 is shown. If I want to see another result, I must to write again the 
word on the omnisearch box. I would like screen 2 is shown one more time when 
coming back from screen 3. Is there any option for that? "

Original comment by martin.v...@gmail.com on 7 Mar 2015 at 8:19

GoogleCodeExporter commented 9 years ago
Ok, I have misunderstood the user. What he wanted is to not to clear the live 
search results when returning back to the main activity with omnisearch prefill 
set to clear. Marking therefore as fixed and re-closing this bug.

Original comment by martin.v...@gmail.com on 7 Mar 2015 at 2:16