mvysny / aedict

Original Aedict 2 source codes
http://www.aedict.eu
GNU General Public License v3.0
40 stars 7 forks source link

Verb and Adjective Conjugation Tables #756

Open dovej opened 7 years ago

dovej commented 7 years ago

The inflections pane is cool. I like the inclusion of common grammatical patterns like 「方がいい」with English translations. However, it does not quite replace the functionality of a full, traditional conjugation table.

The verb and adjective conjugation tables in the free app "Jsho" is a good example of the sort of functionality I think would be useful. My guess is that it just pulls from the same data that JMDict's web client conjugation tables do.

There are three other issues I've found discussing this, which seem to imply that the feature already exists: https://github.com/mvysny/aedict/issues/43, https://github.com/mvysny/aedict/issues/111, https://github.com/mvysny/aedict/issues/119, but I have not been able to find the feature in Aedict3 despite digging through all the settings, clicking everywhere, etc. I'm guessing those issues were just carry overs from Aedict2 or something. If the feature does exist in Aedict3, some more obvious indication might be good, like a dedicated pane (similar to the current inflections pane) or a pop-up tip.

Separately, this data manages to get conjugations for irregular verbs correct (する verbs, くる verbs, 行く, etc.), so I wonder if it could be sourced to improve the existing inflections pane, which fails on very simple cases like する and 行く.

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/44771638-verb-and-adjective-conjugation-tables?utm_campaign=plugin&utm_content=tracker%2F13546219&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F13546219&utm_medium=issues&utm_source=github).
mvysny commented 7 years ago

That is definitely true. There have been a long outstanding bug #486 since the conjugation table UI is ancient. Yet the bugs linked by you do not really help:

Now with that out of the way, we can discuss possibilities of the new UI. I'm thinking some form of combination of the Jsho table with the current list. I'd like to keep the list since it's a great reference guide, but I'd also love to have the Jsho table.

Rgd the suru/iku bugs: can you please open a separate bugs regarding those?

mvysny commented 7 years ago

Screenshot from jsho, for ideas. jsho_conjugations

mvysny commented 7 years ago

Could you please attach screenshots of the "Polite", "Negative" and "Past" screens?

Maybe Aedict's conjugation table UI could be improved to resemble the Jsho's screen; when you touch the form a list of examples can be shown, as in the current UI. You could then be able to switch between five modes:

dovej commented 7 years ago

screenshot_20170503-190553 screenshot_20170503-190604 screenshot_20170503-190614 screenshot_20170503-190624 screenshot_20170503-190633 screenshot_20170503-190640 screenshot_20170503-190647 screenshot_20170503-190823 screenshot_20170503-190831 screenshot_20170503-190837 screenshot_20170503-190845 screenshot_20170503-190852 screenshot_20170503-190902 screenshot_20170503-190908 screenshot_20170503-191317 screenshot_20170503-191330

dovej commented 7 years ago

Sorry for the massive flood of huge images.

That's an exhaustive (I think) set of screenshots for the conjugation ui for a regular v5u and regular adj-i. As seen, the buttons at the bottom are actually switches, and you can turn multiple on at once to get compound conjugations.

mvysny commented 7 years ago

Ooookay, so Jsho is able to show selected combinations. More complex than I expected, however that is a great idea! Let me steal this idea :-D