mvysny / aedict

Original Aedict 2 source codes
http://www.aedict.eu
GNU General Public License v3.0
40 stars 7 forks source link

Reorder category (tag) "move after" #835

Closed bengaskin closed 6 years ago

bengaskin commented 6 years ago

I use tags / categories pretty heavily (I'll use the two terms interchangeably as I believe does aedict3). Every time I create a new tag it gets ordered at the top of the list.

To reorder a tag I click into that tag from the word/kanji that i found it by then click the tag title at the tab at the top of the tag entry and choose reorder tag.

I'm then given the full list of tags in a menu titled "move after".

However the actual operation that is performed is a move-before.

It seems this could be fixed either by adjusting the operation or just by updating the menu name to "move before".

mvysny commented 6 years ago

Thanks! There actually is a difference. The notepad, along with its categories, is intended for the user to create a list of kanjis or words. For example, you could create a list of words you need to study for an exam; then you can simply quiz yourself from that category.

On the other hand, tags only serve to attach a piece of info to a word or kanji. For example, you could attach a hint, a piece of info from the "Remembering Kanji" book on how to remember a particular kanji. For example, for the "Black" kanji you could attach the "burning computer" text ;)

Back to the bug. I think we're talking about the Notepad and Categories, so I'll stick to this terminology. Say that I have three categories, named A, B and C. You click on 'A', then choose 'Reorder this category', then in the 'Move After' dialog you choose C. On my phone, the category gets properly ordered after C and now the order is B, C, A. However, if this is not the case on your phone, then please let me know.

bengaskin commented 6 years ago

Hi Martin,

Agreed, I'll use the category / notepad terminology. I have a category labeled "tag" in my example below so I hope that won't confuse things.

There is definitely still an issue on my phone (Galaxy S6 edge, lollipop).

Screenshots below. I searched for test, found a Kanji word/phrasecalled テストケース, created a new category called testaug18.

I wanted to put it alphabetically between the categories "tag"and "two alternate writings" in this notepad(?) / list of categories.

... proper names tag two alternate writings ...

Logically I believe the correct thing to do would be "move after" the "tag" category. But instead of getting:

... proper names tag testaug18 two alternate writings ...

... I got this result instead:

... proper names testaug18 tag two alternate writings ...

I'm sure you'll agree this is not the intended behavior.

Cheers Ben

On Thu, Aug 2, 2018, 19:58 Martin Vysny notifications@github.com wrote:

Thanks! There actually is a difference. The notepad, along with its categories, is intended for the user to create a list of kanjis or words. For example, you could create a list of words you need to study for an exam; then you can simply quiz yourself from that category.

On the other hand, tags only serve to attach a piece of info to a word or kanji. For example, you could attach a hint, a piece of info from the "Remembering Kanji" book on how to remember a particular kanji. For example, for the "Black" kanji you could attach the "burning computer" text ;)

Back to the bug. I think we're talking about the Notepad and Categories, so I'll stick to this terminology. Say that I have three categories, named A, B and C. You click on 'A', then choose 'Reorder this category', then in the 'Move After' dialog you choose C. On my phone, the category gets properly ordered after C and now the order is B, C, A. However, if this is not the case on your phone, then please let me know.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mvysny/aedict/issues/835#issuecomment-409888598, or mute the thread https://github.com/notifications/unsubscribe-auth/ACEj4xZ8n_Rh8HoFToTH8g8UcM1jcK2Gks5uMttygaJpZM4UqnlB .

bengaskin commented 6 years ago

Screenshots now attached

On Thu, Aug 2, 2018, 20:54 Ben Gaskin bgaskin@gmail.com wrote:

Hi Martin,

Agreed, I'll use the category / notepad terminology. I have a category labeled "tag" in my example below so I hope that won't confuse things.

There is definitely still an issue on my phone (Galaxy S6 edge, lollipop).

Screenshots below. I searched for test, found a Kanji word/phrasecalled テストケース, created a new category called testaug18.

I wanted to put it alphabetically between the categories "tag"and "two alternate writings" in this notepad(?) / list of categories.

... proper names tag two alternate writings ...

Logically I believe the correct thing to do would be "move after" the "tag" category. But instead of getting:

... proper names tag testaug18 two alternate writings ...

... I got this result instead:

... proper names testaug18 tag two alternate writings ...

I'm sure you'll agree this is not the intended behavior.

Cheers Ben

On Thu, Aug 2, 2018, 19:58 Martin Vysny notifications@github.com wrote:

Thanks! There actually is a difference. The notepad, along with its categories, is intended for the user to create a list of kanjis or words. For example, you could create a list of words you need to study for an exam; then you can simply quiz yourself from that category.

On the other hand, tags only serve to attach a piece of info to a word or kanji. For example, you could attach a hint, a piece of info from the "Remembering Kanji" book on how to remember a particular kanji. For example, for the "Black" kanji you could attach the "burning computer" text ;)

Back to the bug. I think we're talking about the Notepad and Categories, so I'll stick to this terminology. Say that I have three categories, named A, B and C. You click on 'A', then choose 'Reorder this category', then in the 'Move After' dialog you choose C. On my phone, the category gets properly ordered after C and now the order is B, C, A. However, if this is not the case on your phone, then please let me know.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mvysny/aedict/issues/835#issuecomment-409888598, or mute the thread https://github.com/notifications/unsubscribe-auth/ACEj4xZ8n_Rh8HoFToTH8g8UcM1jcK2Gks5uMttygaJpZM4UqnlB .

mvysny commented 6 years ago

Thank you, you are right! I was able to reproduce the bug. The bug only applies when you use the File storage type. Since the File storage type is going to go away at some point in near future, you can switch to the newer UMN now, to get rid of the bug. You can do this simply by going to Settings / Expert / Storage Type and select UMN. It is labeled experimental but it works very well for me. Please let me know if this option works for you.

bengaskin commented 6 years ago

Hmm, changing to UMN definitely doesn't work. As soon as I click on move after and select the category it should come after... ...The app crashes with "Unfortunately, Aedict has stopped".

What happens if I try to change back to file type? After I changed to UMN I got a warning not to change back to file type. The warning I got was about creating new data.

Will I lose my existing data? I have a lot of time invested in making custom categories for the 200 or so kanji that are in RTK volume 1 (5th and 6th editions at least) since the 2010 jouyou revisions but still don't have an English description (a previously logged bug).

Thanks

Ben

On Thu, Aug 2, 2018 at 9:19 PM, Martin Vysny notifications@github.com wrote:

Thank you, you are right! I was able to reproduce the bug. The bug only applies when you use the File storage type. Since the File storage type is going to go away at some point in near future, you can switch to the newer UMN now, to get rid of the bug. You can do this simply by going to Settings / Expert / Storage Type and select UMN. It is labeled experimental but it works very well for me. Please let me know if this option works for you.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mvysny/aedict/issues/835#issuecomment-409906593, or mute the thread https://github.com/notifications/unsubscribe-auth/ACEj4_xMF6NWpDVeqLrEKpeamzbmqII1ks5uMu43gaJpZM4UqnlB .

-- Ben Gaskin +81 80 4969 2366 bgaskin@gmail.com

bengaskin commented 6 years ago

PS, restarted phone, no change.

On Thu, Aug 2, 2018 at 10:07 PM, Ben Gaskin bgaskin@gmail.com wrote:

Hmm, changing to UMN definitely doesn't work. As soon as I click on move after and select the category it should come after... ...The app crashes with "Unfortunately, Aedict has stopped".

What happens if I try to change back to file type? After I changed to UMN I got a warning not to change back to file type. The warning I got was about creating new data.

Will I lose my existing data? I have a lot of time invested in making custom categories for the 200 or so kanji that are in RTK volume 1 (5th and 6th editions at least) since the 2010 jouyou revisions but still don't have an English description (a previously logged bug).

Thanks

Ben

On Thu, Aug 2, 2018 at 9:19 PM, Martin Vysny notifications@github.com wrote:

Thank you, you are right! I was able to reproduce the bug. The bug only applies when you use the File storage type. Since the File storage type is going to go away at some point in near future, you can switch to the newer UMN now, to get rid of the bug. You can do this simply by going to Settings / Expert / Storage Type and select UMN. It is labeled experimental but it works very well for me. Please let me know if this option works for you.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mvysny/aedict/issues/835#issuecomment-409906593, or mute the thread https://github.com/notifications/unsubscribe-auth/ACEj4_xMF6NWpDVeqLrEKpeamzbmqII1ks5uMu43gaJpZM4UqnlB .

-- Ben Gaskin +81 80 4969 2366 bgaskin@gmail.com

-- Ben Gaskin +81 80 4969 2366 bgaskin@gmail.com

mvysny commented 6 years ago

Hi, it should be safe to change back to File type - only the things you've added or modified while in the UMN mode will be gone. I have the crash report, but with an empty stack trace. Brilliant, Crashlytics /sarcasm

bengaskin commented 6 years ago

Cool, cheers. I'm used to treating the move after as a move before so I'll carry on as before.

On Thu, Aug 2, 2018, 22:10 Martin Vysny notifications@github.com wrote:

Hi, it should be safe to change back to File type - only the things you've added or modified while in the UMN mode will be gone. I have the crash report, but with an empty stack trace. Brilliant, Crashlytics /sarcasm

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mvysny/aedict/issues/835#issuecomment-409920462, or mute the thread https://github.com/notifications/unsubscribe-auth/ACEj49_9fVIJlCPOhawPQr6cI5jeBPYfks5uMvpGgaJpZM4UqnlB .

mvysny commented 6 years ago

Hmm, Crashlytics reports

java.lang.NoClassDefFoundError: com.gitlab.mvysny.umn.core.MvstoreUMN$update$1
       at com.gitlab.mvysny.umn.core.MvstoreUMN.update(MvstoreUMN.kt:86)

but the class is definitely there... what's going on? Oh Android, you exception generator platform.

mvysny commented 6 years ago

I have removed MultiDex which could be the cause of the NoClassDefFoundError crash. Hopefully in the next version it will work for you as well.

mvysny commented 6 years ago

Please upgrade to Aedict 3.50.6 and try again. The UMN works for me well on all of my devices. Closing, please reopen if the bug reappears.

mvysny commented 6 years ago

The NoClassDefFoundError occurs even without MultiDex, created a new bug report for it #848