search

mvysny / aedict

Original Aedict 2 source codes
http://www.aedict.eu
GNU General Public License v3.0
40 stars 7 forks source link

suru verbs inflection not found #954

Closed rbleuse closed 3 years ago

rbleuse commented 3 years ago

When looking for a suru verb with an inflection, the entry is not found.

For example, the deinflector deinflects menshimasu into mensiru, mensu and menshiteimasu into mensu, that's why the entry is not found.

mvysny commented 3 years ago

That sounds like a bug in the deinflection engine, could you please open a bug report at https://gitlab.com/mvysny/jputils/-/issues ?

mvysny commented 3 years ago

Blocked by https://gitlab.com/mvysny/jputils/-/issues/1

mvysny commented 3 years ago

Fixed in Aedict 3.50.21

rbleuse commented 3 years ago

Hi Martin,

I updated to 3.50.21 but I don't see any changes to this issue : looking for めんします doesn't give me the entry 面する

Anything wrong between jputils and aedict ?

mvysny commented 3 years ago

Hmm that's weird. I've just released jputils 2.1 from the newest master and that's what Aedict 3.50.21 is using, so the bug should be fixed... However I can reproduce the bug on my phone so it's definitely not fixed. Reopening, I'll investigate.

rbleuse commented 3 years ago

It seems that v5s verbs are well found, but not vs-s :

mvysny commented 3 years ago

The problem was that both "suru" verb (vsi) and "noun+suru" verbs (vss) fell into the same category in jputils (InflectableWordClass.VerbSuru); Aedict then assumed that VerbSuru is "suru" only (vsi) which effectively disabled deinflection search for vss. Fixed in https://gitlab.com/mvysny/jputils/-/commit/926fc61de13f303b70d056c6a5435db2386601ed .

I've added tests for the "面します" deinflection to Aedict as well and I'm running the test suite; if all tests pass I'll release new jputils.

mvysny commented 3 years ago

Fixed in Aedict 3.50.22