search

mvysny / karibu-testing

Vaadin Server-Side Browserless Containerless Unit Testing
Apache License 2.0
105 stars 14 forks source link

Vaadin 7 Support #120

Closed jorginius closed 1 year ago

jorginius commented 1 year ago

Hello,

I am trying to port a very old Vaadin app with zero tests. Is it possible to use Karibu Testing with Vaadin 7? The documentation talks about Vaadin 8 but on the Old Vaadin Forum @mvysny said (Emphasis mine 😄):

The Karibu Testing framework may be exactly what you're looking for. It supports both Vaadin 8 and Vaadin 10; adding Vaadin 7 support is very easy. https://github.com/mvysny/karibu-testing

Any hints?

Thank you

mvysny commented 1 year ago

Hi, Vaadin 7 and Vaadin 8 frameworks are very similar (the initialization procedure is similar), therefore Karibu mocking code should work with vaadin 7 as well. You can try to change vaadin8_version=7.x.x in gradle.properties then rebuild karibu, to see whether karibu would work out of the box; if not then it might require simple fixes here and there.

Unfortunately Vaadin 7 is no longer officially supported ( https://vaadin.com/docs/v7/ ) and there are not that many Vaadin 7 projects anymore, so I can not allocate much time to this. However, if it can be shown that Vaadin 7 support can be added easily, then it's easy for me to fork vaadin 8 code and release.

jorginius commented 1 year ago

Thanks, i will try.

I think it's not worth releasing for Vaadin 7 at this point. I will copy your v8 code in the project directly while I'm working on the port. If I find any problem, I will try to make pull request.

There would be no licensing problem, right? (It is a closed-source software)

mvysny commented 1 year ago

There would be no licensing problem, right? (It is a closed-source software)

No problem there. Karibu uses a permissive Apache license which allows code usage in closed-source projects. Please feel free to use the code in any way you need 👍

mvysny commented 1 year ago

Closing as WON'T FIX as discussed above.