mvysny / karibu-testing

Vaadin Server-Side Browserless Containerless Unit Testing
Apache License 2.0
105 stars 14 forks source link

Vaadin 24 #136

Closed mvysny closed 1 year ago

mvysny commented 1 year ago

Add support for Vaadin 24. Since Vaadin 24 depends on new jakarta 5 servlet api, this probably it impossible for the same Karibu codebase to support both Vaadin 14, 22, 23 and 24. Therefore, we may need to create a branch 1.3.x which would target Vaadin 23 and lower, while master branch would target Vaadin 24+.

mvysny commented 1 year ago

Yeah, it's not possible: KT internally uses javax.servlet.ServletContext and passes it to LookupServletContainerInitializer.onStartup() which takes javax.servlet.ServletContext in Vaadin 23 and jakarta.servlet.ServletContext in Vaadin 24 as its parameter.

We need separate branches. This could also be an opportunity to clean out old Vaadin 14 hacks.

That also unfortunately means that we need to maintain two branches. No problem, it's fine :)

mvysny commented 1 year ago

Blocked by: vaadin-spring 24.0.0.alpha5 depends on Spring 3.0.0.rc1 which is not present in maven central.

Tasks:

mvysny commented 1 year ago

I should use vaadin-spring-24.0.0.alpha9 with Vaadin 24.0.0.alpha5 which then uses Spring boot 3.0.0

mvysny commented 1 year ago

Sounds good! Vaadin 24 support implemented on master. I'll close this ticket and make a preliminary release :+1: