mvysny / karibu-testing

Vaadin Server-Side Browserless Containerless Unit Testing
Apache License 2.0
105 stars 14 forks source link

MultiSelectComboBox Karibu 1.3.21 #145

Closed satorstefan closed 1 year ago

satorstefan commented 1 year ago

Hello Martin,

Support for MultiSelectComboBox(Since Karibu-Testing 1.3.21) Should be available.

But yet despite using version 1.3.23</karibu.version> I cannot find that static methode.

Could you please check?

mvysny commented 1 year ago

Hi, according to https://github.com/mvysny/karibu-testing/tree/master/karibu-testing-v10#support-for-multiselectcombobox you need to pull in the karibu-testing-v23 dependency. Have you tried that please?

satorstefan commented 1 year ago

This should be ok, right? image

satorstefan commented 1 year ago

Or do you mean this? image

satorstefan commented 1 year ago

Should I switch to this? image

satorstefan commented 1 year ago

Then this dependency is missing: image

satorstefan commented 1 year ago

Now I understand this comment "Make sure to depend on karibu-testing-v23 to gain access to these functions."

satorstefan commented 1 year ago

And there is even another comment "For Vaadin 23, use karibu-testing-v23 instead (starting with Karibu-Testing 1.3.16)."

Ok, I thought just 1.3.23</karibu.version> would be enough to configure everything.

So the question then is how to use karibu-testing-v23 with spring?

mvysny commented 1 year ago

Hi, you're right, the documentation should have been clearer. I've improved the readme and added more information here: https://github.com/mvysny/karibu-testing/tree/master/karibu-testing-v10#using-karibu-testing-with-spring

Please let me know whether it makes sense. In short, if you need both Vaadin 23 integration and Spring integration, simply depend on both karibu-testing-v10-spring and karibu-testing-v23 Maven modules.

I've also upgraded https://github.com/mvysny/t-shirt-shop-example so that it demoes both Vaadin23 and Spring integrations.

satorstefan commented 1 year ago

Hello Martin, now it makes sense and works.

Thanks alot!