mvysny / karibu-testing

Vaadin Server-Side Browserless Containerless Unit Testing
Apache License 2.0
105 stars 14 forks source link

ErrorView not working on 2.1.5 version #171

Open avdhootu27 opened 2 months ago

avdhootu27 commented 2 months ago

I have an error view in my vaadin app which is supposed to be shown when user tries to open a view which doesn't exist. When I was on vaadin 23 and karibu-testing-v10-spring 1.3.24, I had a test running successfully in which I was navigating to a view which doesn't exist, and I was testing if it returns my ErrorView. Now I am on vaadin 24.3.10 and karibu-testing-v10-spring 2.1.5, the test is failing, it is returning the home (default) view. Why this test is failing on vaadin 24 karibu 2.1.5? The expected behaviour is it returns ErrorView.

mvysny commented 2 months ago

Can you please provide a simple code which reproduces the issue?

avdhootu27 commented 1 month ago

@mvysny Here are 2 projects which has ErrorView functional (in both), one with vaadin 23, karibu 1.3.24 and another with vaadin 24 and karibu 2.1.5.

In vaadin 23 and karibu 1.3.24, the test is passing In vaadin 24 and karibu 2.1.5, the test is not passing (ErrorView is not getting rendered in test)

Functionality wise both are working as expected. flow-spring-examples-v24.zip flow-spring-examples-v23.zip

avdhootu27 commented 1 month ago

@mvysny will it be fixed in upcoming releases?