SearchSpecJ seems to be missing theme-related matchers

mvysny / karibu-testing

Vaadin Server-Side Browserless Containerless Unit Testing

Apache License 2.0

105 stars 14 forks source link

SearchSpecJ seems to be missing theme-related matchers #172

Closed TheHaf-at-FraunhoferIOSB closed 1 month ago

TheHaf-at-FraunhoferIOSB commented 1 month ago

I saw in the documentation that it should be possible in SearchSpec/SearchSpecJ to define a matcher for themes/withoutThemes. The respective methods are available in SearchSpec, but apparently not in SearchSpecJ, if I understand correctly.

I could try to create a PR if you are interested.

mvysny commented 1 month ago

You're right, thanks for pointing it out. Please feel free to create a PR for master; I'll then cherry-pick it for 1.4.x. You can mimic the withClasses()/withoutClasses() function pair.

TheHaf-at-FraunhoferIOSB commented 1 month ago

Alright, I'll create a PR right away. :+1: