search

mvysny / photocloud-frame-slideshow

Android Digital Photo Frame
https://www.android-photo-frame.eu
15 stars 1 forks source link

SMB support stopped working in 1.13.4 #100

Closed mvysny closed 5 years ago

mvysny commented 5 years ago

It seems that upgrading from jcifs 1.3.18 to jcifs 1.3.19 broke samba support completely for one guy, what the fuck, that upgrade was supposed to only fix some security vulnerability or something: https://www.jcifs.org/

But maybe the user silently upgraded to Samba 2 or 3 or whatnot and jcifs stopped working.

Possible solutions:

  1. downgrade jcifs to 1.3.18
  2. use https://github.com/AgNO3/jcifs-ng
  3. use https://github.com/hierynomus/smbj

Big question is whether any of the new libraries actually work, and with which Samba versions, and whether they work on Android.

jcifs has not been maintained since 2013 so perhaps it's time to switch.

mvysny commented 5 years ago

jcifs-ng seem to be API-backward compatible - good! However there are issues: https://github.com/AgNO3/jcifs-ng/issues/160 and https://github.com/AgNO3/jcifs-ng/issues/161

jcifs-ng looking good, but for now I'll downgrade to 1.3.17. On my network, jcifs 1.3.17 is able to enumerate servers while jcifs-ng can't; jcifs is able to throw SmbAuthException while jcifs-ng can't. Staying with jcifs for now.

mvysny commented 5 years ago

Fixed in 1.13.5