search

mvysny / photocloud-frame-slideshow

Android Digital Photo Frame
https://www.android-photo-frame.eu
15 stars 1 forks source link

Add option for "zoom"-scale only for Landscape-Pictures #149

Closed Dax88 closed 3 years ago

Dax88 commented 3 years ago

Hi, perhaps you can add an option to aply the Scale Type "zoom" only for landscape-pictures. In my case i use a tablet in landscape mode. If I enable the scale type "zoom", my landscape-pictures are fine but my portrait-pictures are zoomed in to much. The same option would be grate for the "Panorama pan" effect - i just want to enable this effect for my landscape photos. It is ok if there are black bars left and rigth of my portrait pictures...

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/96106951-add-option-for-zoom-scale-only-for-landscape-pictures?utm_campaign=plugin&utm_content=tracker%2F53303527&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F53303527&utm_medium=issues&utm_source=github).
mvysny commented 3 years ago

Scale Type "zoom" only for landscape-pictures. In my case i use a tablet in landscape mode. If I enable the scale type "zoom", my landscape-pictures are fine but my portrait-pictures are zoomed in to much.

Would enabling the "Fit" Scale Type resolve the issue?

The same option would be grate for the "Panorama pan" effect

Would you like to have a setting to only enable "Panorama pan" effect for landscape photos, and "Static" Effect + "Fit" Scale Type for portrait (so that they don't scroll vertically)?

Dax88 commented 3 years ago

Would enabling the "Fit" Scale Type resolve the issue?

With the "Fit" Scale Type enabeled i have black bars left and right (because the aspect ratio is different to the screen).

Would you like to have a setting to only enable "Panorama pan" effect for landscape photos, and "Static" Effect + "Fit" Scale Type for portrait (so that they don't scroll vertically)?

Sounds good!

mvysny commented 3 years ago

Excellent! Now I need to figure out how to make this configurable in the easiest way :-)

I'll probably add the following boolean setting:

Only apply (the effect) to Landscape; If checked, portrait photos will always use the 'Static' Effect.

mvysny commented 3 years ago

Implemented in PhotoCloud 1.14.2