Open rajdude opened 2 years ago
Hello Martin, A couple of years have passed, and I would really like to get this fixed. Can I pay you something to get it done? In the past I had posted a bounty on a fix I really needed, but that website (bountysource) is now gone. Is there any other way to put a bounty on my issue?
-Raj
THANK YOU Martin for looking at this :-)
Today, I was using another app - "File manager plus" to view my .dng photos. It is able to show them, next-previous buttons also work on my TV remote, but it has the exact same problem as PC. Portrait orientation photos are shown sideways by that app also. So I did a little bit more research, and on the internet, I hear that that happens because the raw file converter being used by the app has some setting which needs to be set, or the library needs to be changed. For example, here is one developer of a different app having the same problem and eventually fixing it… https://github.com/immich-app/immich/issues/546
More specifically, I quote from that thread: After small insight, I found that the problem come from our libraries exifr and sharp. I have also tried on 2 other libs (exiftool and exiv2) and both gave good results. I think this issue may be fixed with #232 once we have selected the appropriate library for reading and writing exif data.
Not sure if this is the same problem in our PC app.
PS: I sent an e-mail to the developer of file manager plus. Lets see what he says.
One more thing I would like to mention. In my first post above, I said this: Note: If I disable the "try loading thumbnails from RAWs" setting, portrait format .dng images are now displayed correctly. I said that in 2022
Today, when I test this, this is no longer true. Even if I disable that setting, the portrait format .dng images are still shown sideways. I did clear PC's cache. I tested this on my TV fed by an NVIDIA Shield box and also on my Google Pixel 5 phone. Same result.
I disable that setting, the portrait format .dng images are still shown sideways
That's good to have a consistent behavior at least :) .
The way this works is that libraw
library loads the RAW image; then I use com.android.support:exifinterface:28.0.0
to load the EXIF data from the RAW and rotate it manually in-memory. There could be number of ways this could go wrong:
Unfortunately PhotoCloud is now in maintenance mode - I have no time to develop it further, and only critical bugs will be fixed.
Martin, I understand your situation. Would it help if I paid you to fix this? How about 20 bucks?
My problem is - your app is literally the ONLY app for Android which does what I want (slideshow of .dng photos from my own server over SMB network connection). So, other than me trying to write an app myself (which I have zero experience with) I have no other way to run a slideshow when my TV is idle. All my hundreds of thousands of photos keep sitting on my server :-(
Thank you kindly for your generosity, while it doesn't fix the underlying problem - that the app can't make reasonable money on Google Play - it's definitely not anything. Perhaps if you could attach one of the RAW images here (you can zip it, then you will be able to attach it here), I could then investigate what's wrong. But unfortunately I can't promise anything at this point.
Thanks for trying, Martin. Here is a sample .dng photo in the portrait format from my camera (it was too big to attach here, even after zipping it) https://1drv.ms/i/c/dbeaf136655aa37c/EYlrTqbq-oNOqkAfVPeASUEBVnASvth9lSh_fKUrwUjX-A?e=2bT3xJ
Thank you. I've downloaded the image and I can unfortunately see the problem right away: the DNG files apparently do not have any EXIF data associated. On my Linux:
exif portrait\ sample.DNG
Corrupt data
The data provided does not follow the specification.
ExifLoader: The data supplied does not seem to contain EXIF data.
That means that PhotoCloud doesn't know that the photo is rotated, and can't rotate it correctly. The DNG parser library PhotoCloud uses, apparently ignores this setting too, since it loads the image unrotated.
I unfortunately don't think there's much I can do... I'm using the libraw library, unknown version, and that's pretty much all that exists on Android AFAIK. I'll keep this bug open so hopefully someone can point me to a better RAW-loading library, but until then there's not much I can do.
Your best bet is to mass-convert those RAWs to JPEGs. You can keep RAWs for editing while leaving JPEGs to be shown by PhotoCloud.
Hello Martin, Would it be possible to fix this issue?
If the "try loading thumbnails from RAWs" is enabled, a portrait format image in a .dng file is displayed incorrectly. (It is shown rotated 90 degrees counter-clockwise).
Note: If I disable the "try loading thumbnails from RAWs" setting, portrait format .dng images are now displayed correctly. However two problems are there:
Thank you for checking this out -Raj