mvysny / photocloud-frame-slideshow

Android Digital Photo Frame
https://www.android-photo-frame.eu
15 stars 1 forks source link

Flickr Photos only display thumbnails (in browse mode). Full photos in slideshow mode show "This photo is no longer available". #47

Open William-o opened 6 years ago

William-o commented 6 years ago

Does not seem to make a difference whether the photos are set to private or public. I can see most of the thumbnails in browse mode as thumbnails but when I tap on a photo to see a larger size it pops up with the Flickr error message "This photo is no longer available". Slideshows result in all photos coming up with the Flickr error message image.

(BTW- thank you for making this app. This is by far the most versatile and properly implemented cloud-based photo slideshow app I have found, and the settings available satisfy almost every need I have.)

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/51703034-flickr-photos-only-display-thumbnails-in-browse-mode-full-photos-in-slideshow-mode-show-this-photo-is-no-longer-available?utm_campaign=plugin&utm_content=tracker%2F53303527&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F53303527&utm_medium=issues&utm_source=github).
mvysny commented 6 years ago

I'm sorry to hear that the Flickr integration doesn't work for you. Let me try to reproduce the issue. Could it be that some security feature of Flickr is allowing Photocloud to only see a thumbnail of the picture? Let me try with my own account.

mvysny commented 6 years ago

Reproduced, thanks!

mvysny commented 6 years ago

Apparently the photo is not big enough so the 2048 size is not available. However, I am unable to detect available sizes of the photo: https://stackoverflow.com/questions/47555939/flickr-flickr-photos-getsizes-always-return-1-photo-not-found

mvysny commented 6 years ago

Related Flickr discussion: https://www.flickr.com/groups/api/discuss/72157689026027831/

mvysny commented 6 years ago

The problem is that Flickr fails to report available photo sizes and thus photocloud assumes.that the photo of size 2048 is always available. Sometimes it is (if the photo is big enough), sometimes there isn't, and then Flickr responds ok with an image which says that the image is unavailable (WTF).

William-o commented 6 years ago

That certainly seems like an issue but I'm not confident that it can describe what's happening to my Flickr feed. I can share a url privately with you if it would help you debug but I'd rather not post it here (it is a public Flickr album, however). All the photos were uploaded at original resolution and were taken on either a Nexus 5X (12MP), a Pixel (12.4MP) or a Nikon D7200 (22MP) and 2048 sizes and larger are available. Weird... Flickr's API must have some other strange secret that is causing issues with my photos, I think.

mvysny commented 6 years ago

That may be true - for example 2048 images may only be available for "pro" Flickr users. Let me try smaller images. No need to share the images for now - I also have Private images and I'm able to reproduce the issue. Let me try a workaround with the smaller images.

mvysny commented 6 years ago

It seems that fetching the image of size 1600 works for me: I am getting the actual images instead of that pesky "This photo is no longer available" photo. So this is a temporary workaround until Flickr figures out how to retrieve photo sizes properly. Workaround will be available in PhotoCloud 1.10.1

mvysny commented 6 years ago

Apparently Flickr doesn't give a shit about their broken API and will probably never fix it. Closing as won't fix, workaround has been implemented.

bfx commented 4 years ago

Does the API is fixed now? Or how can I use the workaround? Actually I'm trying to open images bigger than 2048 and receive a FileNotFoundException

mvysny commented 4 years ago

Unfortunately there has been no communication whatsoever from Flickr. The workaround is in place (PhotoCloud is fetching the images of size 1600 instead of the original images), however if the workaround doesn't work for you then I need to revisit the workaround.

Could you please attach the image here? You may need to zip it in a zip archive though, because of github limitations.

The problem is described at https://stackoverflow.com/questions/47555939/flickr-flickr-photos-getsizes-always-return-1-photo-not-found

Generally I need to figure out in which sizes the photo is available. There is an API call for that (getSizes()), however when I call it, Flickr responds that there is no such photo. The workaround for me is to therefore blindly fetch the photo at size 1600px. However, the photo may not exist at such size, and hence the FileNotFoundException.

So the workaround is not 100% working I guess. However, until Flickr makes getSizes() to work properly again, there is no way for PhotoCloud to learn of proper size of the image.

Which PhotoCloud version are you using please?