jhult
commented
4 years ago I think the above exception is okay. I inadvertently caused this by switching away from a DataLoader and using setItems (with my List) directly on a Grid. I did this because of the real issue: Grid no longer implements HasDataProvider. I believe fix is to update eu.vaadinonkotlin.vaadin10.vokdb.DataProviders similar to the following:
import com.github.mvysny.vokdataloader.DataLoader
import com.github.vokorm.KEntity
import com.vaadin.flow.data.provider.DataView
import com.vaadin.flow.data.provider.HasDataView
import eu.vaadinonkotlin.vaadin10.DataLoaderAdapter
import eu.vaadinonkotlin.vaadin10.VokDataProvider
/**
* Sets given [dataLoader] to this [Grid], by the means of wrapping the [dataLoader] via [DataLoaderAdapter] and setting it
* as a (configurable) [com.vaadin.flow.component.grid.Grid.Grid.getDataProvider].
*/
fun <T: KEntity<*>, V: DataView<T>> HasDataView<T, V>.setDataLoader(dataLoader: DataLoader<T>) {
setItems(dataLoader.asDataProvider())
}
/**
* Returns a [VokDataProvider] which loads data from this [DataLoader].
*/
fun <T: KEntity<*>> DataLoader<T>.asDataProvider(): VokDataProvider<T> = DataLoaderAdapter(this) { it.id!! }eu.vaadinonkotlin.vaadin10.DataLoaderAdapter.DataLoaderAdapter needs some updates as well:
import com.vaadin.flow.data.provider.HasDataView
/**
* Sets given [dataLoader] to this [Grid], by the means of wrapping the [dataLoader] via [DataLoaderAdapter] and setting it
* as a (configurable) [Grid.getDataProvider].
* @param idResolver provides unique ID for every item. The ID is then used to differentiate items.
* See [com.vaadin.flow.data.provider.DataProvider.getId] for more details. Typically every item
* has a primary key of type [Long], but any Java/Kotlin object with properly written [Any.equals] and [Any.hashCode] can act as the ID,
* including the item itself.
*/
fun <T: Any, V: DataView<T>> HasDataView<T, V>.setDataLoader(dataLoader: DataLoader<T>, idResolver: (T)->Any) {
setItems(dataLoader.asDataProvider(idResolver))
}
mvysny
There are updates needed to support the new DataProvider improvements that are being done in Vaadin #8054.
Example: