search

mvysny / vok-orm

Mapping rows from a SQL database to POJOs in its simplest form
MIT License
21 stars 4 forks source link

Implementation InFilter and NotFilter Converters #16

Closed anm-cb closed 2 years ago

anm-cb commented 2 years ago

Implementations for InFilter and NotFilter SQL-Converters. https://github.com/mvysny/vok-orm/issues/15# I could not get jdbi to map e.g. an Array automatically onto a parameter so I had to split the list into multiple parameters for the InFilter.

Maybe an interesting sidenote: jdbi supports resolving arrays with named parameters like (<parameter>), which can be bound with bindList, this didn't work with vok-orm however.

mvysny commented 2 years ago

Awesome work, looks great! Let's wait for the test to succeed on all databases, then I'll pull. Also thank you for creating those filter tests, I wonder why they were missing in the first place - I'll have to create them :+1: