mw99 / DataCompression

Swift libcompression wrapper as an extension for the Data type (GZIP, ZLIB, LZFSE, LZMA, LZ4, deflate, RFC-1950, RFC-1951, RFC-1952)
Apache License 2.0
286 stars 57 forks source link

Missing info in the license file #8

Closed omidontop closed 6 years ago

omidontop commented 6 years ago

The following line in the license file should be filled by the copyright owner:

Copyright {yyyy} {name of copyright owner

mw99 commented 6 years ago

No. It's only an example appendix you would copy into other files. While doing so, you would insert your copyright information. Like in src file

omidontop commented 6 years ago

@mw99 I disagree. Look at this one as a reference:

https://github.com/airbnb/lottie-ios/blob/master/LICENSE

And also, CocoaPods uses these LICENSE files to automatically generate an acknowledgement markdown document which can be used in the credits page of the app. Look at: 'Pods/Target Support Files/Pods-Target/Pods-Target-acknowledgements.markdown'.

mw99 commented 6 years ago

Well... I'm sorry... but you, Airbnb and CocoaPods are all wrong^^

First, it's an Appendix, you may look that up.

Second, it's clearly says in the license what to do:

APPENDIX: How to apply the Apache License to your work. To apply the Apache License to your work, attach the following boilerplate notice, with the fields enclosed by brackets "{}" replaced with your own identifying information. (Don't include the brackets!) The text should be enclosed in the appropriate comment syntax for the file format. We also recommend that a file or class name and description of purpose be included on the same "printed page" as the copyright notice for easier identification within third-party archives.

I mean, in case you are right, it would say something like: "Enter your copyright information down below". But it does not.

And third, let's take a look at how Apache web server uses it. They came up with the license, so they should know best right? https://github.com/apache/httpd/blob/trunk/LICENSE

However, if you can get the Apache guys to change it, I promise I will as well. 😊