mwageringel / fgb_sage

A Sage interface for FGb (Gröbner basis computations)
MIT License
30 stars 0 forks source link

Installation fails on yay-installed Sage #2

Closed upbqdn closed 3 years ago

upbqdn commented 4 years ago

I'm trying to install the package into Sage 9.1 and I can't get over the following error: ... Applying patches. sh: sage-apply-patches: command not found Failed to apply patches.

The error pops out when running 'sage setup.py test'. I'd be happy to fix it on my own and perhaps submit a pull request, but I'm stuck at this.

upbqdn commented 4 years ago

Similarly to the first issue, I solved this one by using a self-compiled version of Sage. It might be useful to mention this detail in the docs. Now fgb_sage works flawlessly with Sage 9.1. I'd still gladly submit a pull request as regards the docs if there's any will.

slel commented 4 years ago

Could you say how the other Sage was installed? Via a package manager? apt, conda, pacman, rpm, yum?

upbqdn commented 4 years ago

Sure, I used this package https://www.archlinux.org/packages/community/x86_64/sagemath/, which I installed using the package manager yay on Arch Linux.

slel commented 4 years ago

You could maybe reopen this issue and change the title to "State assumptions on how Sage was installed". I think a pull request to amend the docs would be nice. What do you think @mwageringel?

slel commented 4 years ago

The first two issues in this repo could be renamed:

slel commented 4 years ago

So maybe open a third issue for improving the docs, and refer to those!

mwageringel commented 4 years ago

Thanks for bringing this up. I was not aware of this – apparently the script sage-apply-patches is only available in Sage the distribution, but in some packaged versions of Sage it is not. I have added a few words about this to the documentation.

The simplest way to fix this might be to copy that file into this repository.

Regarding #1 , the version of Sage (8.1) might just have been too old.

mwageringel commented 3 years ago

This should be fixed now, finally, at least on Arch. Feel free to reopen if there is still a problem on another distribution.