search

mwalbeck / nextcloud-breeze-dark

A Breeze Dark theme for Nextcloud
GNU Affero General Public License v3.0
313 stars 56 forks source link

black app icons on main navigation bar #338

Open gerbrent opened 1 year ago

gerbrent commented 1 year ago

Bug description

Reported via social media here

Summary:

"If one chooses a light color (e.g yellow or light green) while using the Breeze Dark theme, the app icons in the menu bar turn black when it'd be nice if they were white like the system icons."

image

Steps to reproduce

  1. Change theme to Breeze Dark (or presumably any dark theme)

Expected behavior

Icons would be more legible if they we're assigned an appropriate contrast to the theme menu background. In the case of Breeze Dark, white app icons and text are preferable.

mwalbeck commented 1 year ago

Thanks for reporting!

It's a slightly tricky one to deal with, and even the official dark theme has inconsistencies in how well it handles certain scenarios. It has been an issue for quite a while, but due to lack of time and limited reports hasn't been a priority. The lack of time is an even bigger factor at the moment, so it's probably not something I'll get around to anytime soon, but if someone is interested in submitting a PR to fix it, I would be happy to review and merge it.

Anyway, I do have a quick workaround for anyone who is affected by this issue, you can add the following snippet to the custom styling box in the theming settings:

.header-left .app-menu-main .app-menu-entry img,
.header-left #nextcloud .logo.logo-icon {
    filter: invert(0) !important;
}