search

mwalbeck / nextcloud-breeze-dark

A Breeze Dark theme for Nextcloud
GNU Affero General Public License v3.0
318 stars 57 forks source link

Add support for NC28 #340

Closed darkfishy closed 2 months ago

darkfishy commented 3 months ago

Fixes #339 Doesn't seem to break anything on our prod install. @mwalbeck Please review.

darkfishy commented 3 months ago

No JS or CSS files have been modified, so I suspect that the checks are failing on master too.

mwalbeck commented 2 months ago

No JS or CSS files have been modified, so I suspect that the checks are failing on master too.

That is indeed correct

Thanks for the help, especially with testing, it's much appreciated!

IgorA100 commented 2 months ago

@mwalbeck @darkfishy Why was NC27 support disabled? I think we should have left NC27 support and added NC28

mwalbeck commented 2 months ago

@mwalbeck @darkfishy Why was NC27 support disabled? I think we should have left NC27 support and added NC28

It's just how the versioning for the theme is set up, so v27 of the theme only supports v27 of NC and so on. That's also why there is a branch for each major version of the theme, so updates can still be made to previous releases if necessary. I've done it quite a bit in the past, backporting changes whenever they were applicable to the previous release of the theme.

The reason for why I set it up this way, is not as applicable any more, but there used to be quite a lot of changes needed between major Nextcloud releases to support the next release. So it was quite a lot easier to make completely separate releases of the theme instead of trying to make them compatible with each other.

IgorA100 commented 2 months ago

Thanks I got it.