search

mwalbeck / nextcloud-breeze-dark

A Breeze Dark theme for Nextcloud
GNU Affero General Public License v3.0
320 stars 56 forks source link

files_markdown: add styling for syntax highlighting #45

Closed Aviortheking closed 5 years ago

Aviortheking commented 5 years ago

Below is a is snippet but its not coloring nor the text in itself. image

mwalbeck commented 5 years ago

Where exactly in Nextcloud is this? What app?

Aviortheking commented 5 years ago

it's this one https://apps.nextcloud.com/apps/files_markdown

mwalbeck commented 5 years ago

Okay thanks, I'll take a look.

mwalbeck commented 5 years ago

Okay, so I've had a quick look and I need to add CSS for the syntax highlighting. It would be a great help if you could post some code snippets where you notice styling problems, then I can quicker add some syntax highlighting that works with this theme.

Aviortheking commented 5 years ago

there are pre-done highlighters already available like this one: https://github.com/highlightjs/highlight.js/blob/master/src/styles/a11y-dark.css (personal favorite :wink: )

and many more available to test: https://highlightjs.org/static/demo/

but if you want code snippets, a copied the ones on the link above and made it in markdown: https://cloud.delta-wings.net/index.php/s/TKXww69aQLr6T72

mwalbeck commented 5 years ago

Oh okay, great. Thank you for the links, it should be a lot easier than I first expected.

Aviortheking commented 5 years ago

Your welcome :smile:

mwalbeck commented 5 years ago

Okay, I've decided to include the highlighting theme you recommended. I might look at making a highlighting theme based on the Breeze Dark highlighting theme but for now there are other things for this theme I would rather work on. Syntax highlighting is hard to get right.

Aviortheking commented 5 years ago

OK thanks for your work :blush: