search

mwallraf / napalm-ciena-saos

Napalm Community driver for Ciena SAOS
Apache License 2.0
1 stars 0 forks source link

PyPI release #1

Open mirceaulinic opened 4 years ago

mirceaulinic commented 4 years ago

Hi @mwallraf - thanks for writing this driver! Are you planning on releasing this package on PyPI? Also, let me know if you want to move / fork the repo on https://github.com/napalm-automation-community/ for more visibility. Cheers!

mwallraf commented 4 years ago

Hi @mirceaulinic, I haven't had the time lately to continue with this and although the driver is working well enough for our own purposes I haven't been able to extensively test it. I'm ok to move it to the community repo, perhaps someone else can spend more time on it and take care of releasing the package :-) Thanks!

mirceaulinic commented 4 years ago

I have created https://github.com/napalm-automation-community/napalm-ciena-saos and gave you Admin rights - but the decision is entirely yours if you wanna push your commits there, etc. But yes, in general, being in a central collection together with other community drivers may give some more traction and potentially contributors (but don't have great expectations with that :laughing:) Let me know if you need any help, or have any questions! :wink:

mirceaulinic commented 4 years ago

Re: publishing, I have pretty good experience with GitHub Actions, and it's very easy to enable. Basically just commit the changes from https://github.com/mwallraf/napalm-ciena-saos/new/develop?filename=.github%2Fworkflows%2Fpythonpublish.yml&workflow_template=pythonpublish (hope the link works like this), while adding PYPI_USERNAME and PYPI_PASSWORD (your pypi.org/ credentials) as secrets under the repo settings, and then whenever you make a new GitHub release it's going to publish the package on PyPI for you.

mwallraf commented 4 years ago

That's great! I'll move the repo this weekend and check your advise on the publishing part. I use GIT a lot but my "real" job is not related to development so I'm certainly no expert. I really appreciate your help!

mwallraf commented 4 years ago

@mirceaulinic, I have moved all files to the community repo.

FYI - I also have drivers for OneAccess OneOS 5 and Cisco WLC. I don't mind moving them as well if you want. https://github.com/mwallraf/napalm-ciena-saos + https://github.com/mwallraf/napalm-cisco-wlc

mirceaulinic commented 4 years ago

Sure, as you prefer - I have created https://github.com/napalm-automation-community/napalm-oneaccess-oneos and https://github.com/napalm-automation-community/napalm-cisco-wlc if you wanted to move them. Note however that we encourage that drivers under the napalm-automation-community to be maintained (or someone to be able to help, at least) should there be any issues or PRs to review. I'd probably be able to help with the Ciena SAOS one, but not with these 2 for WLC and OneAccess, so it's totally up to you. BTW: if you put your PyPI credentials under https://github.com/napalm-automation-community/napalm-ciena-saos/settings/secrets (neither I or someone else is going to see them, so don't worry), I'll publish the package on PyPI - I can use my username if you don't want to, but it's your work and think it's best to be under your own account. Fine by me if you think otherwise.