JavaScript capstone project - API-based webapp(Group)

[Somdotta07]

• Used JavaScript to make websites dynamic and build basic single-page apps.
• Used ES6 syntax.
• Used ES6 modules.
• Used callbacks and promises.
• Used webpack.
• Used the AAA pattern for unit tests.
• Wrote units tests for a JavaScript app.
• Followed Gitflow.
• Solved simple git conflicts.
• Sent and received data from an API.
• Used API documentation for like and comment
• Made JavaScript code synchronous.
• Performed a code review for a team member.

[netlify[bot]]

✔️ Deploy Preview for elastic-galileo-c508f2 ready!

🔨 Explore the source changes: cd15fe6c8fc67fbd86349628978048ba5e59ff23

🔍 Inspect the deploy log: https://app.netlify.com/sites/elastic-galileo-c508f2/deploys/6198a9c72558d80008ceae62

😎 Browse the preview: https://deploy-preview-26--elastic-galileo-c508f2.netlify.app

[Somdotta07]

Thank you for the review. We're extremely sorry for the inconvenience, the site was not working. We completed the project. Let us fix the issue.

[netlify[bot]]

✔️ Deploy Preview for ecstatic-allen-0bf03f ready!

🔨 Explore the source changes: cd15fe6c8fc67fbd86349628978048ba5e59ff23

🔍 Inspect the deploy log: https://app.netlify.com/sites/ecstatic-allen-0bf03f/deploys/6198a9c7a0c9e5000757dfff

😎 Browse the preview: https://deploy-preview-26--ecstatic-allen-0bf03f.netlify.app

[netlify[bot]]

✔️ Deploy Preview for heuristic-kare-637188 ready!

🔨 Explore the source changes: cd15fe6c8fc67fbd86349628978048ba5e59ff23

🔍 Inspect the deploy log: https://app.netlify.com/sites/heuristic-kare-637188/deploys/6198a9c7da7fa9000743a52e

😎 Browse the preview: https://deploy-preview-26--heuristic-kare-637188.netlify.app

[netlify[bot]]

✔️ Deploy Preview for hungry-kare-90391b ready!

🔨 Explore the source changes: cd15fe6c8fc67fbd86349628978048ba5e59ff23

🔍 Inspect the deploy log: https://app.netlify.com/sites/hungry-kare-90391b/deploys/6198a9c7ccae5c000855b0fd

😎 Browse the preview: https://deploy-preview-26--hungry-kare-90391b.netlify.app

[Somdotta07]

We fixed the page deployment issue as reviewed by the previous reviewer

[rukundoeric]

Hi @Somdotta07 && @mwanawabangona,

Great job so far 👏 💯 👍. However, there are few issues we need to address before we move on. Please, check the comments below.

Highlights

• N/A

Required Changes ♻️

• [x] The way you used to fix the issue is not properly. I suppose you fixed it by changing something in dist/index.js which is not correct because you are not allowed to write anything in that file since it will be generated when you run this command: npm run build. In fact, that folder dist/ should be put in .gitignore. And the file that should have been fixed is the one in src/ directory: src/index.html.
  • Explanation: When someone is running your project, he/she is going to run npm run build which is going to take the content of src/index.html and use it to generate dist/index.html and also take the content of src/index.js and use it to generate dist/main.js.

• [x] Github's Files Changed feature, is showing that you have 5000+ files changes which is impossible for this project unless you have committed some files that you are not supposed to commit. I can see that you have committed everything from node_modules/. To fix this issue, the easiest way to do that is to:

  • delete both node_modules/ director and package-lock.json file by running: rm -r node_modules/ and then rm package-lock.json.
  • Then make commit.

  • After making a commit, then add this in .gitignore:

              /node_modules       // the slash should come before not after.
              /dist              

    • Then commit and push. and make sure that node_modules and dist are not listed as a directories on your remote repo.
    • [x] You used eslint-disable for no obvious reason. all of the issues are linebreak-style which can be easily fixed.
    • [x] There are still some commented-codes in you codebase. Kindly remove them and keep your code clean.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

You can also consider:

• [ ] N/A

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

---

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

[Somdotta07]

Changes are done according to the request of the previous reviewer

• Add dist and node_modules in the .gitignore
• removed all linebreak-style
• removed all commented line