search

mwang87 / MetabolomicsSpectrumResolver

Metabolomics Spectrum Resolver/Displayer
https://metabolomics-usi.ucsd.edu/
MIT License
9 stars 1 forks source link

Fixing testing by allowing longer tolerances #147

Closed mwang87 closed 3 years ago

mwang87 commented 3 years ago

Increase from 7 seconds to 20 seconds, we will turn this back down once we dial the resources in on new server.

mwang87 commented 3 years ago

This just changes the timeout for the tests. Retrieving spectra will still fail (and hence the tests will fail) if it exceeds the shorter timeout during third-party retrieval, so I recommend increasing that (temporarily) as well. The main timeout culprit is MassIVE in my experience.

Its a good point, but both things caused issues on the GitHub actions side. I think what was happening at least in my testing is we were flooding with more requests than the server could handle and the median response was a bit under 20 seconds with few failures.

bittremieux commented 3 years ago

Hmm, why is the unit test for the MassIVE task USI failing?

mwang87 commented 3 years ago

Oh is it haha! Let me take a deeper look there then!