mwang87 / MetabolomicsSpectrumResolver

Metabolomics Spectrum Resolver/Displayer
https://metabolomics-usi.ucsd.edu/
MIT License
9 stars 1 forks source link

Dash Interface Refactor #152

Closed mwang87 closed 3 years ago

mwang87 commented 3 years ago

Creating new dashboard at /dashinterface/ for the customization of spectra

mwang87 commented 3 years ago

So it’s still needed I think because it triggers the function to be called on page load. It’s like a dummy input dependency.

On Wed, May 5, 2021 at 6:14 PM Wout Bittremieux @.***> wrote:

@.**** commented on this pull request.

In dashinterface.py https://github.com/mwang87/MetabolomicsSpectrumResolver/pull/152#discussion_r627014102 :

  • Output("usi2", "value"),
  • Output("width", "value"),
  • Output("height", "value"),
  • Output("mz_min", "value"),
  • Output("mz_max", "value"),
  • Output("max_intensity", "value"),
  • Output("annotate_precision", "value"),
  • Output("annotation_rotation", "value"),
  • Output("cosine", "value"),
  • Output("fragment_mz_tolerance", "value"),
  • Output("grid", "value"),
  • ],
  • [Input("url", "pathname")],
  • [State("url", "search")], +) +def determine_task(pathname, search):

Ok, if I understand the code correctly this takes the parameters from the URL and populates the settings? Do we need pathname? It's not used in the method.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mwang87/MetabolomicsSpectrumResolver/pull/152#discussion_r627014102, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAXSEFJ6V2UDDBWYH53MNLTMHUPRANCNFSM423ZBQNQ .

bittremieux commented 3 years ago

Don't be mad Ming, but I changed way too many things. 😳 I think I (mostly) managed to improve the code a bit though. One thing is currently broken: labeling peaks and syncing that with the peak table. The Celery task processing also suddenly stopped working during the day. I don't think I modified that code, but maybe I inadvertently did so.