search

mwarning / openwrt-firmware-selector

OpenWrt firmware selector. With custom image builder support.
https://mwarning.github.io/openwrt-firmware-selector/www/
Creative Commons Zero v1.0 Universal
38 stars 23 forks source link

Link only current download-files #39

Closed FreifunkUFO closed 4 years ago

FreifunkUFO commented 4 years ago

when i build firmware several times in the same browser-window (with different additional packages) i get more and more download-icons. see screenshot, only the two files in the center can be downloaded

FreifunkUFO commented 4 years ago

yast-fehler

screenshot firefox

mwarning commented 4 years ago

hi FreifunkUFO,

we would need to find out if:

  1. this is a bug in the collect.py script
    • how do you call the collect.py script?
  2. this is a bug in the openwrt generation of the JSON metadata
    • can you check if the json files in the image folder have duplicated entries?
FreifunkUFO commented 4 years ago

i am using firefox on https://chef.libremesh.org

the bug can be seen also from other computers. just open it, choose 902acv1 and write some package into "customize". you should now see two more download-icons then me.

maybe files are useful (all 902acv1-generated files) but are not named. (i am also missing the build-log to have a view)

yast-fehler2

mwarning commented 4 years ago

hm, it works for me (Firefox 75.0). What browser version do you use? The json data send from the backend looks fine as well.

mwarning commented 4 years ago

nvm., I saw the same. Not sure how I did it.. EDIT: I forgot to request a build.

mwarning commented 4 years ago

Ok, this is the build server sending information of a bunch of images. @aparcar I think you need to fix your build server.

aparcar commented 4 years ago

Yes I found this problem too and here is the solution. https://github.com/openwrt/openwrt/pull/3091

mwarning commented 4 years ago

Closing this issue here, as this is not a yafs bug.

mwarning commented 4 years ago

thanks @FreifunkUFO for reporting!