mwarning / openwrt-firmware-selector

OpenWrt firmware selector. With custom image builder support.
https://mwarning.github.io/openwrt-firmware-selector/www/
Creative Commons Zero v1.0 Universal
38 stars 23 forks source link

Allow hardware information to be shown #52

Closed mwarning closed 3 years ago

mwarning commented 4 years ago

Allow hardware information to be displayed (CPU, RAM, Flash), if it is present in the JSON data.

Rows are also hidden when there is no data.

mwarning commented 4 years ago

@aparcar is that something nice to have? Not that we use this feature now, but it might become useful in the future.

aparcar commented 4 years ago

Can you show a demo?

EDIT: Or demo data

mwarning commented 4 years ago

https://mwarning.de/yafs/www/ Search for "1&1 HomeServer"

mwarning commented 4 years ago

But it might be nicer to show hardware data to the build data, not on top...

aparcar commented 4 years ago

Beside the design decision, I think this gets quite big the more data you add also becomes less easy merge-able with the OpenWrt profiles.json file. Don't you think it is better to have a second file containing such data?

mwarning commented 4 years ago

A second file might be good idea.

mwarning commented 4 years ago

Anyway, this feature is not something we need right now. But it is interesting to discuss this.

aparcar commented 4 years ago

Fine with me, although I did not see this in action yet.

There are some additional hardware information which could be valuable, some time ago I created a mock up here

The data is available as YAML, not JSON, but could be easily converted. If we'd stick to the YAML we could collaborate with the official OpenWrt wiki and have a community organized database.

A YAML parser for JavaScript exists here

image

mwarning commented 4 years ago

This looks awesome. :-)

But it might be better to setup this in a different project. Both project scopes might be too divergent.

mwarning commented 3 years ago

The code is now easy to extend to allow this. But this is out of the scope of this project. Closing.

aparcar commented 3 years ago

Actually it could be interesting to load such information at some point. It's all available as YAML but could be easily converted to JSON https://github.com/aparcar/devices/blob/main/data/8devices_carambola.yaml