search

mwarning / openwrt-firmware-selector

OpenWrt firmware selector. With custom image builder support.
https://mwarning.github.io/openwrt-firmware-selector/www/
Creative Commons Zero v1.0 Universal
38 stars 23 forks source link

Swapping version after selecting model shows blank page #57

Closed mweinelt closed 3 years ago

mweinelt commented 3 years ago

Selecting a version and model shows the firmware. Swapping out the version gets you a blank page until you reconfirm the model, although the model string is still there.

mwarning commented 3 years ago

Can you provide an example (and the link you were using)? I just tried "TP-Link TL-WDR4300 v1" and switched the version/release. The entry was updated.

mweinelt commented 3 years ago

Ah, I tried the R7800. Between 19.07 and master the target name changed from ipq806x to ipq806x-generic IIRC, so that's a special case.

Update: Hm, no. YAFS on https://firmware-selector.staging.openwrt.org/ shows ipq806x/generic for both.

mwarning commented 3 years ago

There were a lot of name changes (aka cleanup) between 19.07 and master. There is also the ar71xx to ath79 transition. Theses things are causing problems right now.

In particular, I see "Netgear Nighthawk X4S R7800" (19.07.4) and "NETGEAR Nighthawk X4S R7800" (master). The code does not use fuzzy/case insensitive matching when the version is switched. This is the problem here.

I will look into the problem later.

mwarning commented 3 years ago

Fixed. The model should stay selected when a different version is selected (given the device id or device title stay the same between versions/releases).