mwarning / openwrt-firmware-selector

OpenWrt firmware selector. With custom image builder support.
https://mwarning.github.io/openwrt-firmware-selector/www/
Creative Commons Zero v1.0 Universal
38 stars 23 forks source link

Problem with searching model #76

Closed obsy closed 2 years ago

obsy commented 2 years ago

Very strange issue. Example: https://mwarning.github.io/openwrt-firmware-selector/www/?version=SNAPSHOT&target=ramips%2Fmt76x8&id=hilink_hlk-7628n

Tested on chrome (linux) and edge (linux).

mwarning commented 2 years ago

This edge case should be fixed by this: https://gitlab.com/openwrt/web/firmware-selector-openwrt-org/-/merge_requests/86 (will also be applied in this repo)

mwarning commented 2 years ago

Added now. Please test if this fixes your issue.

obsy commented 2 years ago

Yes and no :). If you type HILINK HLK7628N - this opens device. But if you type HILINK HLK7628n (lowercase last letter) - it will stay in the list and need to be clicked manually.

mwarning commented 2 years ago

HILINK HLK7628n isn't a perfect match. So then the select list should open. No? :)

obsy commented 2 years ago

No. Perfect match on 19.07.5 :)

mwarning commented 2 years ago

match

Looks good to me. No perfect match => select list is shown

obsy commented 2 years ago

Ah, ok, so it respect uppercase and lowercase in names. In this case - it is ok.

mwarning commented 2 years ago

yes, we are a bit picky here about what a perfect match is.