mwarning / trigger

Android app to lock/unlock/ring doors. Supports generic HTTPS/SSH/Bluetooth/MQTT and Nuki Smartlock.
GNU General Public License v3.0
134 stars 22 forks source link

lintVitalRelease fails #31

Closed Bubu closed 5 years ago

Bubu commented 5 years ago

The package cannot be build by f-droid (or anyone trying to build it via commandline gradle) because the lintVitalRelease task fails:

:app:lintVitalRelease/home/mhoffmann/projects/oss/fdroiddata/build/com.example.trigger/app/src/main/res/values/array.xml:3: Error: "SetupTypes" is not translated in "de" (German) [MissingTranslation]
    <string-array name="SetupTypes">
                  ~~~~~~~~~~~~~~~~~
/home/mhoffmann/projects/oss/fdroiddata/build/com.example.trigger/app/src/main/res/values/array.xml:8: Error: "SetupTypeValues" is not translated in "de" (German) [MissingTranslation]
    <string-array name="SetupTypeValues">
                  ~~~~~~~~~~~~~~~~~~~~~~

   Explanation for issues of type "MissingTranslation":
   If an application has more than one locale, then all the strings declared
   in one language should also be translated in all other languages.

   If the string should not be translated, you can add the attribute
   translatable="false" on the <string> element, or you can define all your
   non-translatable strings in a resource file called donottranslate.xml. Or,
   you can ignore the issue with a tools:ignore="MissingTranslation"
   attribute.

   By default this detector allows regions of a language to just provide a
   subset of the strings and fall back to the standard language strings. You
   can require all regions to provide a full translation by setting the
   environment variable ANDROID_LINT_COMPLETE_REGIONS.

   You can tell lint (and other tools) which language is the default language
   in your res/values/ folder by specifying tools:locale="languageCode" for
   the root <resources> element in your resource file. (The tools prefix
   refers to the namespace declaration http://schemas.android.com/tools.)

2 errors, 0 warnings
 FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:lintVitalRelease'.
> Lint found fatal errors while assembling a release target.

  To proceed, either fix the issues identified by lint, or modify your build script as follows:
  ...
  android {
      lintOptions {
          checkReleaseBuilds false
          // Or, if you prefer, you can continue to check for errors in release builds,
          // but continue the build even when errors are found:
          abortOnError false
      }
  }
  ...
mwarning commented 5 years ago

fixed https://github.com/mwarning/trigger/commit/005d3706cf85092efe7548655ac03f7b4270771d But for fdroid a new release is needed.