Basic auth throwing illegal argument exception - Githubissues

mwarning / trigger

Android app to lock/unlock/ring doors. Supports generic HTTPS/SSH/Bluetooth/MQTT and Nuki Smartlock.

GNU General Public License v3.0

134 stars 22 forks source link

Basic auth throwing illegal argument exception #67

Closed daniel-j-h closed 2 years ago

daniel-j-h commented 3 years ago

Hey folks, I got around trying out the latest release with basic auth, but it seems like I'm running into an exception.

Here is an example how my command url looks like (I'm using this on my laptop)

http://c18z907f-f9cc-44d5-9dca-11ee5dc4e396:fddc2458-af53-4621-b89e-dfa02bf79410@192.168.1.115/relay/0?turn=on&timer=300

and here is a screenshot of the exception

Screenshot_20211105-111446

which seems to come from here https://github.com/mwarning/trigger/blob/e5ed285b296a1af8a223103a5187bb2f2e32ed63/app/src/main/java/app/trigger/https/HttpsRequestHandler.java#L110

Let me know if I can provide you folks with more information.

Related

mwarning commented 3 years ago

Base64.DEFAULT seems to append a newline (NL+CR). Fixed in https://github.com/mwarning/trigger/commit/3a4d792ad66d6a8eabf63e6ac9d0a95840023b19