search

mwaterfall / MWPhotoBrowser

A simple iOS photo and video browser with grid view, captions and selections.
MIT License
8.75k stars 2.72k forks source link

Reload image after loading failure #202

Open JasonJasonJason opened 10 years ago

JasonJasonJason commented 10 years ago

When an image from the web fails to load, a nice 'X' appears to let the user know that image loading has failed. However, there seems to be no way to 'try again' on loading this image.

Namely, I receive timeouts whenever on a non-ideal connection but would like to give my users the ability to reload a failed image.

Is there any way to currently do this (that I'm missing)? Or could this be an upcoming feature perhaps?

Also, thanks for all your work, MWPhotoBrowser is awesome!

mwaterfall commented 10 years ago

Yeah there's currently no way to initiate a reload, but that's a good idea! Perhaps simply tapping on the cross should get it to retry again. I'll add this to the todo list! Thanks.

ax86 commented 10 years ago

The same issue. Waiting for the feature. Great library by the way!

joneswah commented 10 years ago

The MWBrowser does actually request failed images to reload each time you modify the UI (swipe to next photo or move to grid etc) however the underlying SDWebImage code blacklists any failed URLs. This means "temporary" failures remain permanent. One way you can change this behaviour is by setting a SDWebImage option of "SDWebImageRetryFailed" and force it to retry failed URLs. This could be done in performLoadUnderlyingImageAndNotify in MWPhoto.m. However this is probably not the best solution in all cases such as 404s etc