search

mwaterfall / MWPhotoBrowser

A simple iOS photo and video browser with grid view, captions and selections.
MIT License
8.75k stars 2.71k forks source link

Issue in landscape mode #3

Closed iaguilera closed 13 years ago

iaguilera commented 13 years ago

I tried your photo browser, very nice work but i have an issue... when passing to landscape mode it seems that zoom factor is less than in portrait mode.... when passing to landscape, image is not centered too, and allow to pan it up outside the screen (without zoom)...

Thanks a lot

mwaterfall commented 13 years ago

Hi there,

By design, MWPhotoBrowser reset's the zoom level when changing orientation.

Regarding the image not being centered in landscape mode, could you provide an example image and some steps to reproduce this so I can try and replicate this issue?

Thanks!

iaguilera commented 13 years ago

I used your web images of your demo.

mwaterfall commented 13 years ago

I'm unable to reproduce the issue regarding images not being centred. If you could provide the exact steps you took, starting from the launch of the demo app, then that would be useful.

iaguilera commented 13 years ago

Im doing tests with an old iPhone 3G maybe the problem is with old
screen size?

mwaterfall commented 13 years ago

Interesting. The photo browser has been tested with the iPhone 3G so I'm not aware of any issues with it.

Again, if you could provide the exact steps you took, starting from the launch of the demo app on the iPhone 3G, then that would be useful so I can try and replicate the issue.

iaguilera commented 13 years ago

'm programming with old XCODE 3.1.4, so I created a new project and added your files and resources.

I wanted to compile for iOS 3.1.2, so I did minimal changes:

  1. MWPhotoBroser, setControlsHidden, changed

    [[UIApplication sharedApplication] setStatusBarHidden:hidden withAnimation:UIStatusBarAnimationFade];

to

[[UIApplication sharedApplication] setStatusBarHidden:hidden animated:YES ];

  1. ZoominScrollView.m, setMaxMinZoomScalesForCurrentBounds, commented

    if ([UIScreen instancesRespondToSelector:@selector(scale)]) {

    maxScale = maxScale / [[UIScreen mainScreen] scale];

If I run the project and select multiple photos from Flicker, the first photo appears ok. Then in simulator do a "Hardware - Turn left" and image rotates as attached image1.png, outside screen area...

Do you think this behavior if because of this two minimal changes I did?

Thanks a lot...

2011/5/6 mwaterfall < reply@reply.github.com>

Interesting. The photo browser has been tested with the iPhone 3G so I'm not aware of any issues with it.

Again, if you could provide the exact steps you took, starting from the launch of the demo app on the iPhone 3G, then that would be useful so I can try and replicate the issue.

Reply to this email directly or view it on GitHub: https://github.com/mwaterfall/MWPhotoBrowser/issues/3#comment_1110430

mwaterfall commented 13 years ago

There should be no need to make any changes to get the photo browser to compile for iOS 3.1.x as it should build fine. I would try undoing the changes you have made (and perhaps use the latest committed version) and see if this resolves the issue.

iaguilera commented 13 years ago

But i need to do changes to compile in ios 3.2.1

Enviado desde mi iPhone

El 13/05/2011, a las 18:26, mwaterfall <reply@reply.github.com

escribió:

There should be no need to make any changes to get the photo browser
to compile for iOS 3.1.x as it should build fine. I would try
undoing the changes you have made (and perhaps use the latest
committed version) and see if this resolves the issue.

Reply to this email directly or view it on GitHub: https://github.com/mwaterfall/MWPhotoBrowser/issues/3#comment_1154657

iaguilera commented 13 years ago

I changed this lines because this functions didn't exists in iOS 3.1.x so program crashes in this iOS version

-----Mensaje original----- De: mwaterfall [mailto:reply@reply.github.com] Enviado el: viernes, 13 de mayo de 2011 18:27 Para: isidoroaguilera@gmail.com Asunto: Re: [MWPhotoBrowser] Issue in landscape mode (#3)

There should be no need to make any changes to get the photo browser to compile for iOS 3.1.x as it should build fine. I would try undoing the changes you have made (and perhaps use the latest committed version) and see if this resolves the issue.

Reply to this email directly or view it on GitHub: https://github.com/mwaterfall/MWPhotoBrowser/issues/3#comment_1154657

mwaterfall commented 13 years ago

The unmodified MWPhotoBrowser is designed to work with iOS 3.1 and up, so it shouldn't crash at all. If you're compiling with the 3.x SDK then you will have a compiler warning about the new unrecognised methods, but this won't lead to a crash because they are only conditionally executed. These warnings are fine to ignore when compiling with an older SDK.

If you are experiencing a crash using the native unmodified code then I'd be interested to see where it's crashing.