search

mwaterfall / MWPhotoBrowser

A simple iOS photo and video browser with grid view, captions and selections.
MIT License
8.75k stars 2.72k forks source link

Grid view does not scroll if using UICollectionViewController - targeting IOS 6+ #319

Open ebfhub opened 10 years ago

ebfhub commented 10 years ago

I'm not sure if you intend MWPhotoBrowser to be used with UICollectionView instead of PSTCollectionView, however since I'm targeting IOS >= 7 I thought I'd try this.

By using find & replace it works well, except that the thumbnail grid view does not scroll (IOS 7 and 8). I've found that this is caused by the call to scrollToItemAtIndexPath code in viewDidLayoutSubviews. If this code is moved into viewDidAppear, followed by an additional call to [self.collectionView layoutIfNeeded] then it works fine.

Please let me know if you need more information. thanks

ebfhub commented 10 years ago

As jonasman suggests on #322 , it would be great if there was a user defined build setting or some other way to prevent PSTCollectionView from being included.

jonasman commented 10 years ago

What was the initial idea to use PSTCollectionView ? just to support old ios versions?