mwaterfall / MWPhotoBrowser

A simple iOS photo and video browser with grid view, captions and selections.
MIT License
8.75k stars 2.71k forks source link

Support SDWebImage latest version 4.2.2 #627

Open lifengios opened 6 years ago

lifengios commented 6 years ago

hope update to sdwebimage 4.2.2

erduoniba commented 6 years ago

@ninjinkun hope update to sdwebimage 4.2.2

moinku07 commented 6 years ago

Waiting for the update

moinku07 commented 6 years ago

@lifengios until it's updated by contributors or owner, you can use my update which fixes the dependency issues for SDWebImage 4.2.2.

https://github.com/moinku07/MWPhotoBrowser

pod "MWPhotoBrowser", :podspec =>'https://raw.githubusercontent.com/moinku07/MWPhotoBrowser/master/MWPhotoBrowser.podspec'

jonathanfoster commented 5 years ago

I just tried to install MWPhotoBrowser with SDWebImage pinned to ~> 4.0 and I ended up getting MWPhotoBrowser 0.0.1 installed and couldn't compile due to https://github.com/mwaterfall/MWPhotoBrowser/issues/181. SDWebImage 4.0 has some major memory improvements making it a must have for my use case.

I see this issue has been open for over a year and a half. Any reason it hasn't been updated yet? I see outstanding PRs. Is this project no longer active?