support for servlet 2.3 and jsp 1.2 (eg: WAS 5.1) in esapi 1.4

[GoogleCodeExporter]

From Mungo Carstairs:

The unsupported method calls I removed or modified were:
HttpServletRequest.getLocalAddr(), getLocalName(), getLocalPort(),
getRemotePort()
HttpServletResponse.getContentType(), setCharacterEncoding()
JspTagException constructor with (String, Throwable) arguments
ESAPI classes SafeRequest, SafeResponse, tags package.
WAS 5.1 uses a 1.4 JVM.

Original issue reported on code.google.com by schal...@darkmist.net on 30 Jan 2010 at 3:43

[GoogleCodeExporter]

As of revision 1134 the servlet 2.3 issues should be fixed. 
setCharacterEncoding()
will throw a UnsupportedOperationException if called in 2.3. If folks with easy
access to a 2.3 container could give this a try I would appreciate it.

I still need to add a JSP 1.2 TLD and will leave this issue open until that is 
committed.

Original comment by schal...@darkmist.net on 8 Feb 2010 at 3:58

[GoogleCodeExporter]

I have commited in revision 1195 a JSP 1.2 TLD in
src/main/resources/META-INF/taglib.tld. The url for this version appends 
#jsp1.2 to
distinguish it from the normal version which is in esapi.tld. It is named 
taglib.tld
as a 1.2 container should pick it up there and miss the esapi.tld while a 2.0+
container should see both and distinguish based on the url.

This works for me in tomcat but I don't have a 1.2 or earlier tomcat installed 
to
test just 1.2.

I'm going to close this for now. If this doesn't work in WAS 5.1 reopen it.

Original comment by schal...@darkmist.net on 27 Feb 2010 at 3:46

• Changed state: Fixed