mwaylabs / generator-m-ionic

Advanced workflows and setup for building rock-solid Ionic apps
MIT License
672 stars 134 forks source link

App icon shows cordova icon #459

Open kevalone opened 7 years ago

kevalone commented 7 years ago

I followed the the steps mentioned in icons_splash_screens.md

Added icon.png in res/android/default & res/ios/default

Added below line in config.xml [I am only building app for android]

<platform name="android">
  <icon src="res/android/default/icon.png" />
</platform>

Run below command gulp --cordova "run android"

But the app icon in mobile is cordova icon

I have also tried to remove platform and add it again but it didn't work

Below is more detail OS: Ubuntu 15.10 node : v4.6.0 npm: 3.10.8 cordova: 6.0.0, gulp: 3.9.0

codestorycooked commented 7 years ago

Hi Put your icon and pad in resources folder in root of ionic app. Then run following command Ionic resources. Automatically icons will be generated and for iOS and android with all configurations required. For more info http://ionicframework.com/docs/cli/icon-splashscreen.html

I hope it helps. Thanks Kunal

kevalone commented 7 years ago

Thanks @codestorycooked Your solution didn't work for me. I am using generator-m-ionic for app development Using command ionic resources --icon shows error message Couldn't find ionic.config.json file. Are you in an Ionic project?

Thanks Keval

codestorycooked commented 7 years ago

Hi Which version of iconic you are using? Yes We have to run command in ionic project. And it seems you are using ionic 2. So you need to add config file. Please use this app as reference for app structure except for src folder.

https://github.com/driftyco/ionic-conference-app?files=1

Let me know Thanks. Kunal

kevalone commented 7 years ago

@codestorycooked I am using ionic 1.3.2

codestorycooked commented 7 years ago

Even if you using ionic 1 you require ionic.config.json as you must have update ionic cli.

kevalone commented 7 years ago

icons_splash_screens.md doesn't mention anything like that.

In my other ionic project it works as you have mentioned, but in my current project I am using generator-m-ionic & I have followed steps mentioned in it to replace default icons

Thanks.

MathiasTim commented 7 years ago

hey @codestorycooked and @kevalmalde! You don't have to run the ionic splash screen generator and you don't need to have an ionic project. Although it makes things easier if you are not familiar with icons and splash screens. Because ionic injects the xml code automatically in config.xml.

I assume you just don't have the right (all) resolutions of your icon for the designated device. You can do it manually, but you have to add the specific resolutions and stuff:

See this cordova guide for more information on it. https://cordova.apache.org/docs/en/6.x/config_ref/images.html#android

Sorry for the confusion with our icons guide, we will think about an update there.